Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-convert option dicts to Dict{String, String} #542

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

maxfreu
Copy link
Contributor

@maxfreu maxfreu commented Oct 22, 2023

partly fixes the confusion in #535

@maxfreu maxfreu marked this pull request as draft October 22, 2023 11:20
@maxfreu maxfreu marked this pull request as ready for review October 22, 2023 11:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2023

Codecov Report

Merging #542 (eba0f72) into main (ff90b8f) will increase coverage by 7.93%.
Report is 3 commits behind head on main.
The diff coverage is 34.37%.

@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
+ Coverage   73.06%   80.99%   +7.93%     
==========================================
  Files          59       57       -2     
  Lines        4633     4109     -524     
==========================================
- Hits         3385     3328      -57     
+ Misses       1248      781     -467     
Files Coverage Δ
src/Rasters.jl 100.00% <ø> (ø)
src/methods/mask.jl 90.00% <100.00%> (+0.38%) ⬆️
src/plotrecipes.jl 83.17% <ø> (+9.91%) ⬆️
src/stack.jl 84.47% <100.00%> (+0.09%) ⬆️
ext/RastersArchGDALExt/gdal_source.jl 88.07% <40.00%> (+0.04%) ⬆️
ext/RastersMakieExt/plotrecipes.jl 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rafaqz rafaqz merged commit 1a61491 into rafaqz:main Oct 22, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants